✨ feat(vscode): 审查列可以手动标记为通过

This commit is contained in:
cruldra committed 2026-10-04 10:01:41 +08:00
1 parent 20249d6a08
commit 4094ffa49e
12 files changed
+157 -6

No files matched your search

@@ -55,6 +55,7 @@ export interface BottomTabsProps {
onContinueBrainstorm: (issueNumber: number) => void
onClearSession: (issueNumber: number, kind: 'brainstorm' | 'implement' | 'review' | 'test' | 'prototype') => void
onUpdateAutoReview: (issueNumber: number, value: boolean) => void
onUpdateReviewPassed: (issueNumber: number, value: boolean) => void
onUpdateProfilePath: (issueNumber: number, profilePath: string) => void
onUpdateBrainstormProfilePath: (issueNumber: number, brainstormProfilePath: string) => void
onUpdateTestProfilePath: (issueNumber: number, testProfilePath: string) => void
@@ -171,6 +172,7 @@ export function BottomTabs(props: BottomTabsProps) {
onContinueBrainstorm={props.onContinueBrainstorm}
onClearSession={props.onClearSession}
onUpdateAutoReview={props.onUpdateAutoReview}
onUpdateReviewPassed={props.onUpdateReviewPassed}
onUpdateProfilePath={props.onUpdateProfilePath}
onUpdateBrainstormProfilePath={props.onUpdateBrainstormProfilePath}
onUpdateTestProfilePath={props.onUpdateTestProfilePath}
+32 -5
View File
@@ -2,7 +2,7 @@ import type { Ref } from 'react'
import type { Issue } from '../types'
import { useSortable } from '@dnd-kit/sortable'
import { CSS } from '@dnd-kit/utilities'
import { Lock } from 'lucide-react'
import { Check, Lock } from 'lucide-react'
import { forwardRef } from 'react'
import { cn } from '@/lib/utils'
import { Card } from './ui/card'
@@ -26,6 +26,8 @@ interface IssueCardProps {
ownerLogin?: string
/** 归属人头像 data URI;缺失时回退首字母圆点。 */
ownerAvatar?: string
/** 审查列:手动标通过或改回审查中。 */
onSetReviewPassed?: (issueNumber: number, value: boolean) => void
}
/** 同事工单的归属人标记:有头像用头像,没有就用 login 首字母。 */
@@ -52,7 +54,7 @@ function OwnerBadge({ login, avatar }: { login: string, avatar?: string }) {
}
export const IssueCard = forwardRef<HTMLDivElement, IssueCardProps>(
({ issue, selected, onSelect, depth = 0, locked, lockedPrerequisite, readOnly, ownerLogin, ownerAvatar }, ref) => {
({ issue, selected, onSelect, depth = 0, locked, lockedPrerequisite, readOnly, ownerLogin, ownerAvatar, onSetReviewPassed }, ref) => {
const { attributes, listeners, setNodeRef, transform, transition, isDragging }
= useSortable({ id: issue.id, data: { column: issue.column }, disabled: readOnly })
@@ -72,6 +74,9 @@ export const IssueCard = forwardRef<HTMLDivElement, IssueCardProps>(
(ref as React.MutableRefObject<HTMLDivElement | null>).current = node
}
const showMark = issue.column === 'review' && !readOnly && issue.source !== 'youtrack' && onSetReviewPassed != null
const cornerCount = (showMark ? 1 : 0) + (locked ? 1 : 0) + (readOnly && ownerLogin ? 1 : 0)
return (
<Card
ref={setRefs as unknown as Ref<HTMLDivElement>}
@@ -91,6 +96,26 @@ export const IssueCard = forwardRef<HTMLDivElement, IssueCardProps>(
: undefined}
>
<div className="absolute right-1.5 top-1.5 flex items-center gap-1">
{showMark
? (
<button
type="button"
className={cn(
'grid size-3.5 place-items-center rounded-sm hover:bg-black/10 dark:hover:bg-white/10',
issue.reviewPassed === true ? 'text-green-400' : 'text-amber-400',
)}
data-tooltip={issue.reviewPassed === true ? '已通过,点击改回审查中' : '标记为已通过'}
aria-label={issue.reviewPassed === true ? '改回审查中' : '标记为已通过'}
onPointerDown={e => e.stopPropagation()}
onClick={(e) => {
e.stopPropagation()
onSetReviewPassed(issue.number, issue.reviewPassed !== true)
}}
>
<Check className="size-3" />
</button>
)
: null}
{locked
? (
<span
@@ -116,10 +141,12 @@ export const IssueCard = forwardRef<HTMLDivElement, IssueCardProps>(
: null}
<div className={cn(
'truncate',
(locked || (readOnly && ownerLogin)) && 'pr-5',
locked && readOnly && ownerLogin && 'pr-10',
cornerCount === 1 && 'pr-5',
cornerCount === 2 && 'pr-10',
cornerCount >= 3 && 'pr-14',
issue.column === 'review' && (issue.reviewPassed === true ? 'text-green-400' : 'text-amber-400'),
)}>
)}
>
<span className="font-mono opacity-60">
{issue.source === 'youtrack' ? issue.externalId : `#${issue.number}`}
</span>
@@ -119,6 +119,8 @@ interface IssueDetailPanelProps {
onClearSession: (issueNumber: number, kind: 'brainstorm' | 'implement' | 'review' | 'test' | 'prototype') => void
/** Persist a per-issue `autoReview` override into the state JSON. */
onUpdateAutoReview: (issueNumber: number, value: boolean) => void
/** 审查列手动标记通过。 */
onUpdateReviewPassed: (issueNumber: number, value: boolean) => void
/** 已知 Claude profile 列表,用于「配置文件」下拉选项。 */
profiles: ClaudeProfile[]
/** Persist a per-issue `profilePath` override into the state JSON. */
@@ -180,6 +182,7 @@ export function IssueDetailPanel({
onContinueBrainstorm,
onClearSession,
onUpdateAutoReview,
onUpdateReviewPassed,
profiles,
onUpdateProfilePath,
onUpdateBrainstormProfilePath,
@@ -559,6 +562,14 @@ export function IssueDetailPanel({
type: 'boolean',
description: `打开新 PR 时是否自动启动 codex 审查;未设置时跟随全局(当前全局:${globalAutoReview ? '开' : '关'})`,
},
...(issue?.column === 'review' && issue.source !== 'youtrack'
? [{
key: 'reviewPassed',
label: '审查通过',
type: 'boolean' as const,
description: '手动标成已通过,标题变绿。新的提交会清掉这个标记。',
}]
: []),
{
key: 'color',
label: '颜色',
@@ -772,6 +783,7 @@ export function IssueDetailPanel({
testSessionId: issue.testSessionId ?? null,
prototypeSessionId: issue.prototypeSessionId ?? null,
autoReview: issue.autoReview ?? globalAutoReview,
reviewPassed: issue.reviewPassed === true,
color: issue.color ?? null,
// 展示/选中值按 basename 映射到本机 profiles,避免跨机绝对路径变成「自定义」项。
brainstormProfilePath: matchProfileOption(issue.brainstormProfilePath, profiles) || null,
@@ -1008,6 +1020,8 @@ export function IssueDetailPanel({
return
if (key === 'autoReview' && issue && typeof value === 'boolean')
onUpdateAutoReview(issue.number, value)
if (key === 'reviewPassed' && issue && typeof value === 'boolean')
onUpdateReviewPassed(issue.number, value)
if (key === 'brainstormProfilePath' && issue && typeof value === 'string')
onUpdateBrainstormProfilePath(issue.number, value)
if (key === 'profilePath' && issue && typeof value === 'string')
@@ -41,6 +41,7 @@ interface KanbanBoardProps {
onColumnChange?: (issueNumber: number, toColumn: IssueColumn, source?: 'gitea' | 'youtrack', externalId?: string) => void
onDependencySet?: (issueNumber: number, prerequisiteNumber: number) => void
onDependencyClear?: (issueNumber: number, prerequisiteNumber: number) => void
onSetReviewPassed?: (issueNumber: number, value: boolean) => void
/** 当前 Gitea login;用于判定哪些卡是同事的(只读)。 */
me?: string
/** Gitea login → 头像 data URI。 */
@@ -117,6 +118,7 @@ export function KanbanBoard({
onColumnChange,
onDependencySet,
onDependencyClear,
onSetReviewPassed,
me,
avatars,
}: KanbanBoardProps) {
@@ -281,6 +283,7 @@ export function KanbanBoard({
readOnly={readOnly}
ownerLogin={ownerLogin}
ownerAvatar={ownerLogin ? avatars?.[ownerLogin] : undefined}
onSetReviewPassed={onSetReviewPassed}
/>
)
})}